Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): randomly assign 2 reviewers with bot #26

Merged
merged 1 commit into from
Oct 19, 2023
Merged

chore(ci): randomly assign 2 reviewers with bot #26

merged 1 commit into from
Oct 19, 2023

Conversation

owen-reorg
Copy link
Collaborator

@owen-reorg owen-reorg commented Oct 18, 2023 •
edited
Loading

Description

Implemented a feature to automatically assign two reviewers to a PR using a bot.

Rationale

This automation streamlines the review process, ensuring that each PR is reviewed by at least two team members, thereby maintaining code quality and consistency.

Example

Upon PR submission, the bot automatically assigns two reviewers from the team.

Changes

Notable changes:

  • Created a script for the bot to randomly select and assign two reviewers to a PR.
  • Integrated the bot script with the existing CI/CD pipeline.

welkin22
welkin22 approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@welkin22 welkin22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-reorg owen-reorg merged commit 4b3ac56 into bnb-chain:develop Oct 19, 2023
1 check passed
sunny2022da pushed a commit to sunny2022da/op-geth that referenced this pull request Aug 11, 2024
@galaio
txdag: opt read txdag file and validation logic; (bnb-chain#26)
875ecc7 
* txdag: support new txdep resolve method;
pevm: avoid read txdag file when generating;

* pevm: support read txdag file in const size;

* txdag: reduce mem alloc and async resolve tx dependency;

---------

Co-authored-by: galaio <[email protected]>
sunny2022da pushed a commit to sunny2022da/op-geth that referenced this pull request Aug 13, 2024
@galaio @sunny2022da
txdag: opt read txdag file and validation logic; (bnb-chain#26)
ff2f727 
* txdag: support new txdep resolve method;
pevm: avoid read txdag file when generating;

* pevm: support read txdag file in const size;

* txdag: reduce mem alloc and async resolve tx dependency;

---------

Co-authored-by: galaio <[email protected]>
sunny2022da pushed a commit to sunny2022da/op-geth that referenced this pull request Sep 25, 2024
@galaio @sunny2022da
txdag: opt read txdag file and validation logic; (bnb-chain#26)
4c41ce4 
* txdag: support new txdep resolve method;
pevm: avoid read txdag file when generating;

* pevm: support read txdag file in const size;

* txdag: reduce mem alloc and async resolve tx dependency;

---------

Co-authored-by: galaio <[email protected]>
sunny2022da pushed a commit to sunny2022da/op-geth that referenced this pull request Oct 11, 2024
@galaio @sunny2022da
txdag: opt read txdag file and validation logic; (bnb-chain#26)
0d2bb8b 
* txdag: support new txdep resolve method;
pevm: avoid read txdag file when generating;

* pevm: support read txdag file in const size;

* txdag: reduce mem alloc and async resolve tx dependency;

---------

Co-authored-by: galaio <[email protected]>
welkin22 pushed a commit that referenced this pull request Oct 22, 2024
@galaio @welkin22
txdag: opt read txdag file and validation logic; (#26)
81a22bc 
* txdag: support new txdep resolve method;
pevm: avoid read txdag file when generating;

* pevm: support read txdag file in const size;

* txdag: reduce mem alloc and async resolve tx dependency;

---------

Co-authored-by: galaio <[email protected]>
sunny2022da pushed a commit to sunny2022da/op-geth that referenced this pull request Nov 14, 2024
@galaio @sunny2022da
txdag: opt read txdag file and validation logic; (bnb-chain#26)
17330d9 
* txdag: support new txdep resolve method;
pevm: avoid read txdag file when generating;

* pevm: support read txdag file in const size;

* txdag: reduce mem alloc and async resolve tx dependency;

---------

Co-authored-by: galaio <[email protected]>
sunny2022da pushed a commit to sunny2022da/op-geth that referenced this pull request Dec 11, 2024
@galaio @sunny2022da
txdag: opt read txdag file and validation logic; (bnb-chain#26)
a81f34d 
* txdag: support new txdep resolve method;
pevm: avoid read txdag file when generating;

* pevm: support read txdag file in const size;

* txdag: reduce mem alloc and async resolve tx dependency;

---------

Co-authored-by: galaio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendanzhentan bendanzhentan bendanzhentan approved these changes

@welkin22 welkin22 welkin22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@owen-reorg @welkin22 @bendanzhentan